Vicente Bolea

Results 156 comments of Vicente Bolea

https://github.com/ornladios/ADIOS2/pull/4125

Hello @crtrott, this is my first PR here, let me know what info/changes you need for this PR. Thanks! :)

@aprokop I can prepare a reproducer let me see what I can do. You cand reproduce with ``` cmake kokkos-src cmake --build . cmake --install . --prefix `usr`/install # From...

@aprokop please find the reproducer here: https://gist.github.com/vicentebolea/a16e2d3c515999723735daa77c016ad7 The issue happens when invoking kokkos_compilation which is needed for the user source files to get the right compilation flags for device adaptors.

> @aprokop please find the reproducer here: > > https://gist.github.com/vicentebolea/a16e2d3c515999723735daa77c016ad7 > > The issue happens when invoking kokkos_compilation which is needed for the user source files to get the right...

> > The issue happens when invoking kokkos_compilation which is needed for the user source files to get the right compilation flags for device adaptors. > > Thank you so...

> This looks good to me but we should just use the workaround described in https://cmake.org/cmake/help/latest/variable/CMAKE_CURRENT_FUNCTION_LIST_DIR.html for `CMake` versions earlier than 3.17. We can discuss raising the minimum CMake version...

> > This looks good to me but we should just use the workaround described in https://cmake.org/cmake/help/latest/variable/CMAKE_CURRENT_FUNCTION_LIST_DIR.html for `CMake` versions earlier than 3.17. We can discuss raising the minimum CMake...

> This pull request should not change the minimum CMake version (which would be a breaking change and there are other places that should be consistent). Rather something like In...