Victor Chudnovsky

Results 75 issues of Victor Chudnovsky

The best way of verifying correct behavior is probably to implement integration tests against the Showcase compliance suite, which test various data types. Context: boolean fields seem to be not...

type: bug
priority: p1

We should do a brief audit of our [ReadTheDocs documentation](https://googleapis.dev/python/gapic-generator-python/latest/index.html) to ensure the information there is still accurate and up to date. Most of the files have not been touched...

type: docs
priority: p2

Implement Showcase integration tests and add them to CI for transport=REST: * with numeric enums turned on * with numeric enums turned off This is arguably a GA blocker for...

type: process
priority: p2

We run generated unit tests in the individual GAPIC repos, and that is as it should be. However, we should also run generated unit tests upstream in the process, as...

type: process
priority: p2

Right now, it looks like for at least some server errors, we do not handle or report them to the user and instead (if we're lucky?) encounter an exception later....

type: bug
priority: p2

This changes the code to expect the correct exceptions

size: xs

As a follow-up to #1390 (or maybe as a way of accomplishing that), we should - require all PRs to either include changes to documentation or to have a tag...

type: process
priority: p2

The top-level `README.rst` is very sparse, and it says that the repository "primarily exists to facilitate experimentation", which is no longer true. We should update the file to say this...

type: docs
priority: p2

Running nox showcase test suites leads to errors of the form `Error processing line 1 of /usr/local/google/home/…/gapic-generator-python/.nox/showcase_alternative_templates/lib/python3.9/site-packages/google-showcase-nspkg.pth` A workaround is to go to the offending file and insert a newline...

type: bug
priority: p2
test coverage

When running tests locally, I get errors of the form `Error processing line 1 of /usr/local/google/home/[...]/gapic-generator-python/.nox/showcase_alternative_templates/lib/python3.9/site-packages/google-showcase-nspkg.pth` Not sure where that line is coming from (maybe `nox`, maybe Showcase itself), but...

type: bug
type: process
priority: p2