Baranov Victor

Results 27 comments of Baranov Victor

I tried locally on commit 74687180dde07312521db09c6f6454fe9d1e5662, and It didn't crash. ```cpp // gh144862.cpp #include int main() {} ``` `./bin/clang-tidy --checks=-*,misc-unused-using-decls gh144862.cpp` I couldn't find any related commits of fixing this...

Oh, I could get the crush on "bugprone-crtp-constructor-accessibility" but it seems you have this rule disabled. Commit 74687180dde07312521db09c6f6454fe9d1e5662, file: ```cpp #include "boost/redis/src.hpp" // 1.88 int main() {} ``` crash: ```...

> there's an underlying bug which reveals itself in different circumstances I've seen an issue about a Heisenbug, though no work was done because of lack of reproduces, I guess....

You could follow these steps assuming you have `ninja`: 1. Run configure in `llvm-project` directory, adjust defines for your system: ``` cmake -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -DCMAKE_C_COMPILER:FILEPATH=/usr/bin/clang -DCMAKE_CXX_COMPILER:FILEPATH=/usr/bin/clang++ -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-g -DLLVM_ENABLE_ASSERTIONS=ON "-DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra'"...

After that, you could use `-clang-tidy-binary` flag in `run-clang-tidy.py` to specify freshly build clang-tidy. I can't recommend any `cmake install` commands since I haven't tested it myself, but they can...

> also, not relevant to the crashes I'm seeing, on other files I get UB san Yes, this patch is already reverted on main because `*-san` builders caught this problem...

As odd as it sounds, but these memory leaks may be intentional, please see https://github.com/llvm/llvm-project/issues/143129

I wonder if behavior of this check should be an extension to [optin.core.EnumCastOutOfRange](https://clang.llvm.org/docs/analyzer/checkers.html#optin-core-enumcastoutofrange). Sure, we don't have `static_cast` here but it's still considered as "cast out of range"? Maybe it's...

@alexandear, are you planning/working this issue? If not, I can try to do the refactor and open a PR in near future.

"Checking for the ability to merge automatically..." message was for the past 6 hours, could you please rebase on fresh main again, maybe some conflicts cause it. I'll merge once...