Baranov Victor

You should use script `./clang-tools-extra/clang-tidy/add_new_check.py` to automatically set up all necessary files. Also, please read https://clang.llvm.org/extra/clang-tidy/Contributing.html. I think it should be in `bugprone` category.

I hear for the first time that people think `constexpr variables inside functions automatically have a static lifetime`. I'd like to warn only when we have ```cpp constexpr int x...

> I didn't know about it being a C++23 extension as mentioned above, that's something people will probably care about. Paper behind it https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2647r1.html > So a static constexpr inside...

> Or should I wait until this is more thoroughly discussed? With [carlosgalvezp](https://github.com/carlosgalvezp)'s summary, I think you could implement first version of the check. The only uncertainty may be the...

> Another aspect is that this is probably only useful when dealing with big objects, typically arrays. Warning on small objects like ints or floats might be too noisy in...

> Even if it can be detected reliably, I find it brittle, because changing one header file can require a change in many places where is used. Maybe that's why...

> the Linux CI checks failed, but the tests passed. I've seen this happen before, seems like a CI issue, not the check issue. I think in a week or...

> I'm unsure about the format, but I'm convinced about the feature I lean towards verbose format. Little formal description of how I see parsing: When we have `[]` after...

I'm personally +- on AI review, but I've seen it is used here. So it could be a good idea to give some knowledge and guidelines for AI to follow.

Good to add: - new rule in README.md and RULES_DESCRIPTION.md must be in lexicographical order by rule name. - new rule must have correct confidence based on its implementation.