Baranov Victor

Results 27 comments of Baranov Victor

Add GitHub Action workflow for testing new rules across popular repositories

With GitHub workflow approach, will the developer be able to run this test suite locally without many problems? I recently tried to run GitHub actions locally and didn't like the...

Add GitHub Action workflow for testing new rules across popular repositories

The golangci-lint bench-suite likely wouldn't intended to run locally, but with this test-suite I'd like to first run it on my machine before submitting a PR

[clang-tidy] Add a new check 'replace-with-string-view'

> How about custom classes like `StringRef` in LLVM? Yes, we should add option `ReplacementStringViewClass` (with std:: by default) for users to specify a custom pre C++-17 class for string_view....

[clang-tidy] Add a new check 'replace-with-string-view'

> Maybe it worth to merge the PR in the current state and then I'll add options support and other optimizations as separate commits not to overcomplicate this PR? Sure,...

[clang-tidy] Add a new check 'replace-with-string-view'

> I prefer "misc-use-string-view" because there is not only one reason to use it. > > Doesn't copy underlying string. Cheap to copy. Can take both std::string and string literals...

[clang-tidy] Add a new check 'replace-with-string-view'

> > ```diff > > getArcana > > ``` > > Thanks. Looks like overloaded functions? So let's ignore overloaded functions as I do for virtual/override? Not always overloaded functions;...

[clang-tidy] Add a new check 'replace-with-string-view'

> > ```c++ > > std::string getArcana(const TemplateName &NNS) { > > return std::string{""}; // no warning, explicit ctor call > > return std::string(""); // no warning > > }...