Valentin David

> @valentindavid can the description or some comment in the code include the actual udev rules that this will be used from? it's a bit unclear just from the code...

> What's the plan for testing the cmd_scan_disk code? I have added tests. I still have to add tests for the changes in `cmd_initramfs_mounts.go` (when `/dev/ubuntu/disk` exists). But that should...

> Before this is merged, there is [one more new plugin about to be merged](https://github.com/fwupd/fwupd/pull/5242) that needs two more things. May as well get it right in one shot. >...

I have added few things to allow UEFI capsules to work.

~~!13278 with https://github.com/snapcore/secboot/pull/266/~~

`tests/nested/core/core20-gadget-reseal` started to fail with: ``` 2023-12-05T17:20:27.3929553Z [ 91.522913] snapd[1922]: 2023/12/05 17:10:31.229509 logger.go:93: DEBUG: 2023-12-05T17:10:31Z ERROR cannot set next boot: cannot reseal the fallback encryption keys: cannot increment counter: TPM...

> I made a pass. An additional change that I wonder if is needed is that in the past parts of secboot were imported in snapd: https://github.com/snapcore/snapd/commit/a466265db2a4f124cca948ed39884d55b9d9a2fe https://github.com/snapcore/snapd/commit/e45a076a6ffd088cfce600db3b1ed8f862204c1d and maybe...

I have added the Block label, because we should not merge it yet. The new key format has to be merged together. But it should still be reviewed.

> lgtm, one question, did Chris have a look a the changes? I do not know if he looked through it.

depends on core22 lastest/stable to have the symlink fix: * `tests/nested/manual/recovery-system-reboot` depends on ubuntu-image being updated with https://github.com/snapcore/snapd/pull/13817: * `tests/nested/manual/uc20-install-in-initrd` * `tests/nested/manual/core20-preseed ` Still need investigation: * `tests/nested/manual/snapd-removes-vulnerable-snap-confine-revs`