Ivan Dlugos

Results 297 comments of Ivan Dlugos

The issue is, as you can see from where the error is thrown, that JavaScript doesn't support 64-bit integers, or rather no higher than `2^53 - 1` From a quick...

> I'm a bit curious about what the JS implemenation of flatbuffers does though. wrapper class https://github.com/google/flatbuffers/blob/d0cede9c90c5257537c293517a21376408b549fa/ts/builder.ts#L580_L582 https://github.com/google/flatbuffers/blob/master/ts/long.ts ```typescript createLong(low: number, high: number): Long { return Long.create(low, high); } ```

Besides, I wonder why dart SDK throws on `setInt64` - that should be safe to implement, right? We obviously have an integer that is in the limited range that JS...

> Not sure what the right time is to start leaning on BigInts.. but they've been in JS for a while now. Hmm, dart already does have those in the...

After [this commit is made](https://github.com/getsentry/sentry-unity/commit/882b8efdb06aea0efdfa6742b2ea25466c943db3), I'd like there to be another one that adds a blank `## Unreleased` section to the changelog.

Yes, it would - that's what the changelog.md looks like anyway - PRs add their items to the `Unreleased` section, then there's a release which just renames it. The first...

> I think what you actually want is a post-release commit to re-add that section yes exactly > having it be part of the release will ship that "Unreleased" header...

That this is failing for you is quite surprising to me though. As mentioned above, we set the default value to [`Application.persistentDataPath`](https://docs.unity3d.com/ScriptReference/Application-persistentDataPath.html) and this seems to work fine on all...

`PrivateSentrySDKOnly` should now be used: https://github.com/getsentry/sentry-cocoa/pull/1960/files#diff-321979279232433e004cfdaab6ac97727ac4aead9a53d2cd77637084d9208277R47

This is fixed by #967 but keeping the issue open in order to track the deprecation & the needed switch to new APIs