Vadim Peretokin

Results 1068 comments of Vadim Peretokin

I think the best direction, still, would be to improve upon the existing C++ widget which is used by several projects (one of them very large).

In Mudlet we had to ditch QScintilla early on because it was crashy. edbee's C++ widget is certainly better than QScintilla, which is what you found when you discovered the...

@gamecreature any thoughts on the PR style?

Which ones do you mean specifically?

Ah. I'd stay away from such a mechanic in my own code.

Could have been there before - Coverity might have picked this up just because this code was changed. It does some weird caching.

Thanks! I will test it out in our builds on windows/linux.

I was confused about the version number that you updated to and I realised that Oniguruma and Onigmo are two different projects :open_mouth: the patch I need is in Oniguruma...

Sublime uses the same font-size but greys out the line number so it doesn't jump out as much - that seems to work well.

Yeah, this can be theme-neutral, but I'd recommend taking the luminosity taking into account - from our experience you want to use 2 colours, one for a light background and...