edbee-lib icon indicating copy to clipboard operation
edbee-lib copied to clipboard

Update Onigmo

Open vadi2 opened this issue 5 years ago • 4 comments

Is it possible to have the version of Onigmo be updated? I need to use the new --enable-posix-api=no flag it introduced.

vadi2 avatar Aug 12 '19 13:08 vadi2

Hi @vadi2, I've updated Onigmo to the latest version 6.2.0. I've tested in on OS X is seems to compile and run. I haven't run any tests with windows/linux. Also cmake hasn't been tested.

I've made a seperate branch for it: https://github.com/edbee/edbee-lib/tree/feature/onigmo_6_2_0

gamecreature avatar Aug 13 '19 14:08 gamecreature

Thanks! I will test it out in our builds on windows/linux.

vadi2 avatar Aug 14 '19 07:08 vadi2

Thanks!

gamecreature avatar Aug 14 '19 07:08 gamecreature

I was confused about the version number that you updated to and I realised that Oniguruma and Onigmo are two different projects :open_mouth: the patch I need is in Oniguruma (https://github.com/kkos/oniguruma/issues/77). I'll work with Onigmo's author to get it in, then we can get the version I need into edbee...

vadi2 avatar Aug 14 '19 07:08 vadi2