Alex Ganose

Results 172 comments of Alex Ganose

Hi @cote3804, this is fantastic. Thank you for contributing it. Firstly, would you be able to send me an email? My address is aganose [at] imperial [dot] ac [dot] uk....

Hi @cote3804, apologies for the delay responding on this. Overall, I think it looks great. I'd just note that in most cases, we have now moved the input sets into...

For your first bug, you will need to specify a settings.yaml file as described in the documentation and in the [examples](https://github.com/hackingmaterials/amset/tree/main/examples/GaAs). For your second error, unfortunately, AMSET is not compatible...

Wow! Thanks for this contribution @ptigas, this is a major addition and something I know many users will be interested in. I'm familiar with Prefect but haven't used it before...

Just noting the [`TransmuterMaker`](https://github.com/materialsproject/atomate2/blob/058a9df0577184ec4d589e73d53484e9bb668fb4/src/atomate2/vasp/jobs/core.py#L576) in case you weren't already aware. There is some overlap here the existing class both applies the transformation and then runs a calculation which is more...

Agreed this is a problem. I'd hoped this would be made easier by having input sets that are not subclassed but what's happened is we now just have loads of...

There has already been some discussion on related issues: - https://github.com/materialsproject/emmet/pull/944 - https://github.com/materialsproject/jobflow/pull/565 - https://github.com/materialsproject/emmet/issues/914 I advised on not removing `as_dict` at the time since it will break downstream packages....

That said, I feel like I'm fighting a losing battle. If moving over to the emmet ValueEnum and using `enum_values=True` in jsanitize doesn't cause any regressions, I'm happy to go...

No need to appologise. I didn't expect you to be familiar with the previous discussions, I was just putting them for the complete history of this problem. Thanks for digging...