Alex Ganose comments

Results 172 comments of


                                            Alex Ganose

[WIP] Generalize forcefields for generic ASE calculator support

Thanks @esoteric-ephemera. Would it be much effort to mock the tblite call so it doesn't have to run in CI? I'll also tag @Andrew-S-Rosen as maybe he has got tblite...

[WIP] Generalize forcefields for generic ASE calculator support

Is this still WIP or can it be merged now?

[WIP] Generalize forcefields for generic ASE calculator support

Hi @esoteric-ephemera. Thanks again for this. Is it ready to merge?

[WIP] Generalize forcefields for generic ASE calculator support

Thanks @esoteric-ephemera, this is very exciting to have!

Single source of truth for optional deps in `pyproject.toml`

This is great, thanks @janosh! Are you able to look into the merge conflict/failing test?

Generalize `download_opls_xml` Function

Thanks @shehan807. This looks good to me. Can you install and run the linter on your changes to ensure they match the style guidelines: https://materialsproject.github.io/atomate2/dev/dev_install.html#installing-pre-commit ``` pip install pre-commit pre-commit...

sumo-dosplot showing error ValueError: invalid literal for int() with base 10: '!'

Please can you provide more information on exactly what command you're running and if possible provide the vasprun.xml

sumo-dosplot showing error ValueError: invalid literal for int() with base 10: '!'

I'm not able to reproduce your error. When I run `sumo-dosplot` on your vasprun.xml file, I get the following plot. [dos.pdf](https://github.com/SMTG-Bham/sumo/files/15470950/dos.pdf)

sumo-dosplot showing error ValueError: invalid literal for int() with base 10: '!'

Ah, please can you also send your KPOINTS file too?

sumo-dosplot showing error ValueError: invalid literal for int() with base 10: '!'

I'm going to close this now as I don't think this is an issue in sumo itself.