Alex Ganose

Results 172 comments of Alex Ganose

Hi, I'm just wondering if there's any update on this issue?

Thanks for the pointer to the zenodo repository.

Unfortunately the projection colours are hardcoded here: https://github.com/SMTG-UCL/sumo/blob/f754c45dbd2f387c8fb0d2dd06c991fdc4f9be0f/sumo/plotting/bs_plotter.py#L627 It would be good to make this customisable.

This is a missing feature which we definitely should support (it is often one of the most common ways of presenting density of states/projected band structures).

It should be simple to add the function you suggest to Pymatgen via either method. I prefer the modifying the existing function tbh. We could then look at implementing this...

Hi @zrqustc, this is correct. But the orientation of the spherical harmonics is determined by the cartesian x, y, and z directions. If bonds between atoms do not fall exactly...

I made a rough diagram indicating what I mean: ![Screen Shot 2019-12-03 at 11 03 02 AM](https://user-images.githubusercontent.com/1330638/70081015-89505680-15bc-11ea-9281-eb1ed8db83a3.png) Note this issue will also affect lm-decomposed density of states...

@badw I know you have a code that can do this. Any interest in combining it into sumo?

Thanks for this, implementation looks nice and clean! Main comment is can you make this pep8 compatible (i.e. 4 spaces for an indent, line length not longer than 80 characters)....