atomate2 icon indicating copy to clipboard operation
atomate2 copied to clipboard

Single source of truth for optional deps in `pyproject.toml`

Open janosh opened this issue 1 year ago • 4 comments

aka DRY extras. related PR https://github.com/janosh/pymatviz/pull/231

plus some code cleanup

janosh avatar Nov 01 '24 14:11 janosh

Hi @janosh , I am a bit confused by this. As far as I understood strict, it was there to give exact version numbers. With this pull request, this would not be true anymore.

JaGeo avatar Nov 01 '24 14:11 JaGeo

@JaGeo you're right. i wanted to use this PR as a test to look into adding a uv.lock file which would replace the strict optional deps entirely. it might be a step towards addressing the pytorch version conflicts you mentioned https://github.com/materialsproject/atomate2/pull/1031#issuecomment-2441823827

janosh avatar Nov 01 '24 14:11 janosh

@janosh ah, thank you for the explanation! 😅

JaGeo avatar Nov 01 '24 14:11 JaGeo

This is great, thanks @janosh! Are you able to look into the merge conflict/failing test?

utf avatar Nov 12 '24 16:11 utf