Taku Amano

Results 239 comments of Taku Amano

What about the following PR approach? https://github.com/honojs/honox/pull/161 The errors in the following projects will be resolved, and the expected results will be achieved. https://github.com/yusukebe/honox-react-nested-islands/tree/island-in-island

Although `fetch()` returns decoded data, the content-encoding and content-length headers remain unchanged in the response, which seems to be causing the problem. On my environment, the following code returned the...

@yusukebe Thank you! > My additional thoughts is if we use useContext depending on the JSX runtime we are using at the time, we can use HasIslands on any JSX...

@yusukebe You're right, we shouldn't add our own keys to "tsconfig.json", we should be able to specify them in `honox()`. ### useContextModule? I have previously named it `useContextModule`, but in...

@yusukebe Hypothetically, I pushed 8fb2913, which was implemented with the above content. In most cases, automatic configuration from tsconfig.json should be fine, but if you want to specify explicitly, you...

@yusukebe Thank you! Indeed, I was also wondering where to put the files. I have changed it in 9638879, please check.

OK, I did think that `site` and `vite` were prone to typo.

I considered it for a while and concluded that we should decode the path component before processing the routing. As @yusukebe says, the place to do this processing is `getPath()`....

@szmarczak Thanks for your comment. Are you saying that you think the router should do this process? We believe that modifying `getPath()` would satisfy the specification. Please be specific about...