Markus Unterwaditzer

Results 849 comments of Markus Unterwaditzer

you can disable the `sentry` feature of statsdproxy to resolve the version conflict. since DDM is dead that feature doesn't make any sense anymore.

actually can you bump statsdproxy crate as well? the sentry feature has been gone for quite a while there

adding filter functionality makes sense, but I'm not sure if you want to actually prune green recordings. in theory these old recordings can be reanalyzed with new heuristics. see #300

yes please. however i'd also add `--reset-config` flag that forcibly overwrites it.

oh nevermind. i didn't read your proposal carefully. i was thinking of something else. with #351 there will be a way to change the config graphically. in that scenario i...

I think we can have `./installer orbic --keep-config` and `./installer tplink --keep-config` and it just skips that one file copy. i would like to still overwrite the config by default...

my concern is that we have multiple flows that are drifting apart, for unclear benefit (install speed? we can probably make the installer faster in a bunch of ways...)

@gaykitty no, i mean having a separate install flow for "first install" vs "upgrade". I think it'd just be more fragmentation..

yeah, there was some discussion on the pr and it seemed like a footgun to put it there. the port setting too, because then we'd have to handle redirecting to...

another thought, the most compelling case for this refactor would be if it puts us in a position where rayhunter could one day update itself on the device, on all...