Markus Unterwaditzer

Results 849 comments of Markus Unterwaditzer

I think the combination of `--auto-offset-reset=earliest` and `--no-strict-offset-reset` sometimes ends in situations where arroyo resets to an offset that already expired, therefore *failing to reset the offset* ``` %4|1729638367.626|OFFSET|rdkafka#consumer-2| [thrd:main]:...

I think it's a race condition in arroyo that allows this to happen. I think we should probably support constructs like `--auto-offset-reset=earliest+1h` to self-serve what we already end up doing...

neat, I'll try to review this on the weekend. do you have a usecase for this or just did it out of curiosity?

> I don't know whats up with the perf, but here are the results on my machine: is that overhead added even to use without spans? I think this is...

sorry for the slow reply. i do prefer your second approach, but it's not a strong preference. i think we really need to figure out what is causing the perf...

I re-ran the benchmarks and I am not sure how i concluded there is a _massive_ perf regression. forget about my previous comment. i like add-spans-2 more than this PR...

@Akida31 i think we can go forward with add-spans-2, don't care if you make a new PR or reuse this one. I don't mind the regressions

superseded by #120

I'm interested in working on this. Tempted to make it work the same as `caches` (and potentially merge it into one dropdown), since that's way easier to implement (doesn't require...

I get the part where you want to rewrite `nitter.net` to `twitter.com` as canonical URL, for example. What I'm less sure about is the part where you want to rewrite...