Unnawut Leepaisalsuwanna

Results 56 comments of Unnawut Leepaisalsuwanna

So as discussed earlier we should be able to derive from `EXIT_PROCESSOR_SLA_MARGIN` and `ETHEREUM_BLOCK_TIME_SECONDS`. Also might be worth using `EXIT_PROCESSOR_SLA_MS` to have the same time unit as most other configs.

cc'ing @kevsul if I missed any other conversations on this one!

A reverse that's rarely used: https://github.com/omgnetwork/elixir-omg/blob/master/apps/omg_db/lib/omg_db/rocksdb/core.ex#L125 ```elixir defp do_filter_keys(reference, prefix) do # https://github.com/facebook/rocksdb/wiki/Prefix-Seek-API-Changes#use-readoptionsprefix_seek {:ok, iterator} = :rocksdb.iterator(reference, prefix_same_as_start: true) move_iterator = :rocksdb.iterator_move(iterator, {:seek, prefix}) Enum.reverse(search(reference, iterator, move_iterator, [])) #

@InoMurko The `Enum.reverse(...)` in `Enum.reverse(search(reference, iterator, move_iterator, []))`. I don't think any of its caller is order-sensitive. [Not a major impact on perf](https://github.com/omgnetwork/elixir-omg/pull/1667/files#diff-0d4a86fbc510a6669d7b5603e2b94509R72-R81) though and [slight impact](https://github.com/omgnetwork/elixir-omg/pull/1667/files#diff-0d4a86fbc510a6669d7b5603e2b94509R83-R93) on memory consumption.

I'm tackling this ticket from the following angles: - **`:authority_balance`** - Stays in `childchain` since it's primarily the operator's concern to topup the balance. - Currently reported only when there's...

> [more like for discussion, probably not too much suitable for the task] > > If there are multiple metrics, we might consider to invest some time to see the...

After more thoughts, fixing the balance is not easy so: - **`:authority_balance`** -> fix later, it reports accurately but just not reporting frequent enough - **`:unique_users`** -> fix later, doesn't...

Sounds good! Would you like to take that on, or leave it as a feature request?

Thanks! Let me know if I can help with anything :)

I wonder though... since packages don't always have a complete license information, we might need some kind of tolerance level. E.g. what to do if the license couldn't be detected,...