Unnawut Leepaisalsuwanna

Results 56 comments of Unnawut Leepaisalsuwanna

Ah I missed the "no URL paths" part. Quite a big change. 😅 My suggestion would then be: 1. Keep the current convention 2. Allow `GET` only on the root...

☝️ My understanding of exits is very limited at the moment so I'm expecting a lot of scrutiny on this one.

> The suggested simplification would drop `cached` completely and only ask for as much events as it's allowed to process. +1. Imho this caching is too close & too tied...

Updated the description as suggested 🎉

Doesn't seem to affect overall system perf so will treat this as low priority

As discussed on the call with @jrhite 1. We might not need `/deposit.get` so soon if we only need the deposits listing for block explorer. 2. `eth_events` can wait until...

In `OMG.ChildChain.BlockQueue`, the [network and contract health is only checked at setup](https://github.com/omisego/elixir-omg/blob/master/apps/omg_child_chain/lib/omg_child_chain/block_queue.ex#L81-L86). From log above we can see that the contracts could become unavailable during block submission. So we need...

Actual error: https://sentry.io/organizations/omisego/issues/1542324859 ```elixir FunctionClauseError: no function clause matching in Ecto.Changeset.cast/4 File "lib/ecto/changeset.ex", line 462, in Ecto.Changeset.cast/4 File "lib/omg_watcher_info/db/eth_event.ex", line 172, in OMG.WatcherInfo.DB.EthEvent.txoutput_changeset/3 File "lib/omg_watcher_info/db/eth_event.ex", line 156, in OMG.WatcherInfo.DB.EthEvent.insert_exit!/1 File...

@InoMurko @achiurizo I've added this one to this cycle's board to propose including this in the cycle. With hope that you'd accept it to the team's todo list 😂 Also...

Also, could you add this change to https://github.com/omisego/elixir-omg/blob/master/CHANGELOG.md under the Unreleased header?