undermyumbrella1
undermyumbrella1
Hi I have created a pr with my attempt at unit tests. May I request for some help reviewing the pr? thank you!
Hi, thank you for the review, I have resolved the comments, may I check which of the private helper functions are not necessary? Thank you!
Hi I have created a pr to try to fix this issue and possibly discuss if my approach is ok. May I request for some help reviewing it? Thank you!
Thank you for the review, I have added comments as per the review.
I have added the issue in the pr, the pr is still work in progress
Hi, I have completed the implementation, may i check why linux test if failing with `NameError: name 'pa' is not defined`, but it works for other os?
``` df = DataFrame({"A": ["c1", "c2", "c3"], "B": [100, 200, 255]}) df["B"] = df["B"].astype("bool[pyarrow]") gb = df.groupby("A") result = gb.agg(lambda x: [1, 2, 3]) print(result["B"].dtype) # list[pyarrow] result = gb.agg(lambda...
Sorry for the delay in resolving the test cases. Originally the approach is to always caste it back to input dtype, even if the output dtype is different. Currenlty the...
Noted, I have made the change according to the comments using `convert_dtypes` and a helper method to account for some unaccounted pyarrow dtypes. Although I am not sure if the...
Thank you for the review, I have updated the pr according to comments.