teammates icon indicating copy to clipboard operation
teammates copied to clipboard

Published 20 hours ago • verified publisher icon TEAMMATES

Add unit tests for `SubmitFeedbackResponsesAction`

Open wkurniawan07 opened this issue 2 years ago • 12 comments

SubmitFeedbackResponsesAction is by far the most important and the most used state-changing API of the system, and yet there are no unit tests for it.

wkurniawan07 avatar May 28 '22 10:05 wkurniawan07

Is anybody working on this? If not can I take it?

chen-ni avatar Jun 14 '22 09:06 chen-ni

Is this still an issue?

Z-Guy avatar Jul 07 '22 19:07 Z-Guy

Hi, Is anyone working on this? Can I take it

N-S-H avatar Jul 30 '22 07:07 N-S-H

Feel free to make a PR for this issue!

zhaojj2209 avatar Jul 31 '22 02:07 zhaojj2209

Can I be assigned the issue if no one is working on it?

rohanshankar avatar Aug 08 '22 14:08 rohanshankar

Can i take up this task to help out ?

mestrag avatar Aug 19 '22 22:08 mestrag

@mestrag Please go ahead

NicolasCwy avatar Aug 22 '22 12:08 NicolasCwy

I was just going to start working on it and I found there is already a test for SubmitFeedbackResponsesAction jn the test package. Am I missing something here ??

akhil9281 avatar Aug 28 '22 17:08 akhil9281

@akhil9281 The existing testcases in SubmitFeedbackResponsesActionTest.java are insufficient; ideally, the testcases should cover all possible behaviours of SubmitFeedbackResponsesAction.

zhaojj2209 avatar Aug 30 '22 06:08 zhaojj2209

Is this still an issue? I'd love to make my first contribution

rakhazachrie avatar Sep 09 '22 09:09 rakhazachrie

Are you still looking for support on this issue?

kaykaym01 avatar Sep 16 '22 05:09 kaykaym01

@kaykaym01 Hi so far there is no PR on this issue, so feel free to work on it.

hhdqirui avatar Sep 16 '22 17:09 hhdqirui

Hi i'd like to tackle this problem, can you assign me?

ghost avatar Sep 23 '22 09:09 ghost

Hi @Serafion, you can start working on the issue.

ypinhsuan avatar Sep 25 '22 01:09 ypinhsuan

hi, thanks for adding to participants. As i looked through the code it is coupled with Logic class, and it takes lot of data from it. Can i mock this class with mockito? without it the test would involve a lot of additional code tested. Antoher solution would be the use of typicalDataBundle.json

ghost avatar Sep 26 '22 07:09 ghost

@Serafion We do not add backend dependencies unless it is really essential. If typicalDataBundle solves the problem, please go ahead with it.

fsgmhoward avatar Sep 26 '22 17:09 fsgmhoward

Hi, I would like to try to work on this issue, can you assign it to me?

cnca2120713 avatar Oct 06 '22 05:10 cnca2120713

@cnca2120713 Feel free to submit a PR for this issue.

zhaojj2209 avatar Oct 06 '22 06:10 zhaojj2209

@zhaojj2209 can i work on it?

tusharrajpoot avatar Oct 08 '22 19:10 tusharrajpoot

Hi @tusharrajpoot, yes, feel free to submit a PR for this issue.

hhdqirui avatar Oct 12 '22 03:10 hhdqirui

Hi @wkurniawan07 , can i work on this issue as my first open source study? TY.

u6656793 avatar Oct 17 '22 06:10 u6656793

can I work on this/ @wkurniawan07

u6358194 avatar Oct 18 '22 03:10 u6358194

@u6656793 @u6358194 There have been many requests to work on the issue yet no PR has been submitted so far, so feel free to work on the issue and we will look at any PRs submitted.

zhaojj2209 avatar Oct 18 '22 06:10 zhaojj2209

Hello, I already setup my local environment and I'm still figuring out what behaviors that still not covered by current test case, any clue?

rakhazachrie avatar Nov 04 '22 04:11 rakhazachrie

Is this issue open? Can you assign it to me if it is?

spiritanand avatar Jan 29 '23 10:01 spiritanand

@spiritanand Feel free to make any PRs that add testcases.

zhaojj2209 avatar Jan 30 '23 03:01 zhaojj2209

Hi I have created a pr with my attempt at unit tests. May I request for some help reviewing the pr? thank you!

undermyumbrella1 avatar Mar 22 '23 06:03 undermyumbrella1

Hi, thank you for the review, I have resolved the comments, may I check which of the private helper functions are not necessary? Thank you!

undermyumbrella1 avatar Mar 22 '23 11:03 undermyumbrella1