Uku Taht
Uku Taht
@Quintasan Port exposure issue was brought up in #4 as well. I think we should just remove the `ports` sections for databases. There is also a PR #1 that allows...
Fair enough, that makes sense. Let's go with the override file. I'll merge this once the docs are ready
I like the change, thanks for submitting. One issue: currently the `PORT` env variable is used by the `plausible` container to determine what port it should run the server on...
Agreed, if you make the change I will merge.
@XzAeRo do you have time to add this? ``` ports: - ${PORT}:${PORT} ``` Happy to merge with this addition.
OK, no problem :)
@tckb thoughts?
I'm confused as to why the container was needed in the first place? I didn't change anything about this knowingly
OK this is weird. I'll test at some point removing the container from my self-hosted installation to see if it has any negative effect.
@Joelius300 Looks good to me, I'd like to get it integrated. Tests are the only thing missing now I think