Uku Taht

Results 112 comments of Uku Taht

> it would be nice if we can get these types of features that make important visual changes to the UI in staging itself so everyone can test there with...

Sorry no, I don't think this will work. I think we need to add another case to to the `shift_back` function in `query.ex`: https://github.com/plausible/analytics/blob/2a4061de8c6fcdfbbdd998981e43c73328e8dbfb/lib/plausible/stats/query.ex#L36 We already adjust the previous period...

Can we close this to reduce the amount of open PRs? Can always refer back to the code or reopen in but it has many conflicts with the ongoing ingestion...

Hey 👋 This PR has conflicts and I wanted to make some changes. Closing this in favour of https://github.com/plausible/analytics/pull/2680 for now

Yes I think the [custom event approach](https://github.com/plausible/wordpress/issues/47#issuecomment-1188951569) proposed by @jdevalk is the best. As he mentioned there's a limitation on filtering/displaying more than a single custom prop at a time....

Thanks @Kylmakalle ! I agree with your analysis and suggestions (mostly) > Perhaps, we need to Skip the Swedish parser for English (are Swedish names better than English, [like Estonian](https://github.com/plausible/location/blob/31f91c4df430cfc16219000ac667cc665826b77c/lib/scraper/scraper.ex#L5-L6)?)...

@ruslandoga could you review since you worked on the Sentry integration?

This one says it's definitely `android-app://com.google.android.googlequicksearchbox`: https://www.cueblocks.com/blog/how-to-optimize-track-google-discover-in-google-analytics/ This one says it's more complicated: https://valentin.app/discover-tracking.html > It seems we should we start storing the referrer_protocol as well - otherwise impossible to...

> Just to double-check, I'm assuming imports are out of scope of this change, for now at least, right? Correct. This change is irrelevant for imports.

More context for future reference: https://github.com/plausible/analytics/discussions/1337