Uku Taht
Uku Taht
Thanks for the extra information @MarcusOtter !
> Tesla has too many abstractions imho In general I'm quite averse to introducing new libraries and layers of indirection as well. I liked the Tesla suggestion because it would...
Thanks @manusajith
Unfortunately we don't have a clean separation between some behaviour we need in the cloud that makes no sense for self-hosters. This happens because new users get a 30-day trial...
Thanks! The solution we went with in the main codebase is using `try-catch` when attempting to read from localStorage: https://github.com/plausible/analytics/blob/d40faf6ec796eee23fcd8525d5b96d7623a05702/tracker/src/plausible.js#L38 What I like about this approach is the brevity of...
I don't see this being wired up to be used by the docker compose file? The `CRON_ENABLED` env var can be safely removed. It is ignored as of v1.2.
Yes, the timeout in https://github.com/plausible/plausible-tracker/blob/a5f8e946263b4e9898c729293f74a095ef71cfcb/src/lib/tracker.ts#L286 should only trigger for links that are not `target="_blank"`. For `target="_blank"` links, browser default behaviour should be allowed to happen as we do in our...
Also, an issue we had on the main tracker script was middle clicking on the mouse to open the link in a new tab. Outbound link tracking was messing with...
When using `target="_blank"`, we just allow the default browser behaviour. This line: `location.href = link.href;` does not run when using `target="_blank"`. So it already respects `target="_blank" rel="noopener"` links.
> BTW, the current behaviour in plausible does stop noopener when not using target="blank" Darn, yeah that's true. I do like the idea of just falling back to browser defaults...