Hubert Chathi
Hubert Chathi
I think that I've addressed all of @florianduros 's concerns. The test failure looks like possible flakiness, since it's testing components that I haven't touched.
@florianduros I've made the changes that you've requested to the test file. I'm afraid that I don't quite understand what you're asking for regarding pulling things out into custom hooks....
@florianduros ping
I've addressed all of Florian's concerns. @richvdh can you give this a crypto team review?
I managed to find another race condition while writing a test, so I need to investigate and fix it.
Strange. One of the tests is now failing in CI, even though I only made a comment change. And I can't reproduce the failure locally. Will need to investigate.
This would require modifying `getSessionIdForDevice` in `src/crypto/OlmDevice.js`, and probably will need to store the time that the client last received a mesage for each session in indexedDB
Being able to "star" messages (#2938) might be better for being able to find something later. But I can see how it could be useful to "mark as unread from...
seems to be fixed now