Hubert Chathi comments

Results 152 comments of


                                            Hubert Chathi

MSC4222: Adding `state_after` to sync v2

Merged! :tada:

Support to declare that a key needs to conform with the given Struct

Maybe the easiest way would be to add a predicate `is_struct?` to check if a `map` is of a struct of a given type?. So something like ```elixir schema do...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

This dialog comes from `CreateSecretStorageDialog`, which is called by `accessSecretStorage` in `SecurityManager.ts`. So I should also update `CreateSecretStorageDialog` to use the new designs (probably by replacing the contents of the...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

Oh, `CreateSecretStorageDialog` is a fun file. I may take this opportunity to do some refactoring...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

> I do not think so, because there should not be any other way to call it (because we decoupled setting up recovery from reset). It's called by the `accessSecretStorage`...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

I've done a survey of the places where `accessSecretStorage` is called. Some of them call it when Secret Storage should already be set up, so shouldn't call `CreateSecretStorageDialog`. Some of...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

> I have the following questions about this: > > 1. How would we show the correct state? I think showing that the "Key Storage" is OFF, would be very...

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

https://github.com/element-hq/element-web/issues/29170 tracks the issue of the Encryption settings dialog being confusing if backup is created by a different client and we don't have the private key

EW still prompts you to "Set up Secure Backup" and "Enter a security phrase"

After discussion, we decided that I would convert all of the places that call `accessSecretStorage` to set up Secret Storage to instead bring the user to the Encryption settings page,...

`New Recovery Method` modal shows on screen with unexpected timing, an outdated message and button text is a bit off?

> I would have expected this popup to show just after the recovery was reset, instead of after sending the next message. This dialog is triggered when key backup is...