John-John Tedro
John-John Tedro
> [Several users are already using the self argument in tokio::main](https://grep.app/search?q=%23%5C%5Btokio%3A%3Amain%5C%5D%5Cn.%2Aself®exp=true&filter%5Blang%5D%5B0%5D=Rust), so I'm not going to accept/approve removing support for self argument. I think a full evaluation demands that it...
439841d fixes `minimal-versions` check by constraining the async-stream dependency to `0.3.2`, which uses the correct minimal version of `proc-macro2` and has removed use of the API which wasn't supported until...
That should be that. Return type heuristics added in dcc8a7a and the preliminary comments should have been addressed so I'm marking this as ready for review. Note that this *does...
@Darksonn that *should* be tokio-rs/tracing#1960 - something could probably be done solely in Tokio but I'm not sure what.
No, we just needed to bump `tracing` to see if it builds and I've been busy. Did it now with a merge so we'll see if it works!
Hm, another one: ``` tokio-util v0.7.0 (D:\Repo\tokio\tokio-util) └── tracing v0.1.32 ├── cfg-if v1.0.0 ├── pin-project-lite v0.2.5 ├── tracing-attributes v0.1.20 (proc-macro) │ ├── proc-macro2 v1.0.23 (*) │ ├── quote v1.0.0 (*)...
PR is in an OK state. It's the minimal versions stuff that is both very time consuming when I sit down with it and I have little motivation to work...
It does seem to block the client from shutting down as claimed (using `ncat`) - but not consistently. I usually have to try a few client and when stuck it's...
So when it blocks, we correctly woke up once on read-readiness. But the attempted call to peek sporadically returned: ```rust Err(Os { code: 10035, kind: WouldBlock, message: "A non-blocking socket...
This makes the issue reproducible on Windows (without ever calling peek). Still works for Linux, so it might very well be an issue in mio w/ polling on Windows: https://github.com/udoprog/tokio/commit/c6c495c273aacf5d0d26b2ea2189cfdf2bc4dac9...