John-John Tedro

Results 237 comments of John-John Tedro

Any approach is fine with me. I prefer ones which avoid allocating if possible. More data about the number can also be extracted during lexing if necessary beyond `is_fractional`, like...

Also we haven't clearly defined which parsing standard we abide by. Lacking that it would be "whatever Rust does". I seem to recall there was some improvement posted about float...

Could you elaborate? What is it that you want to work and what did you try to do? The existing mechanism for overriding how sources are loaded can be specified...

I think only standard included source loaders (possibly configurable) would work with a general purpose language server. Else one would need to provide some way to conveniently build-your-own language server,...

Thanks for the positive reception! I'd be glad to put together a PR as a proposal now that I've gotten a feel for the waters.

So I've got a [work-in-progress branch](https://github.com/udoprog/chrono/commit/fallible-constructors) where I tested some of the above things out, a preliminary review to see if it's on the right track would be nice before...

> I think returning Result for these cases would be mostly more idiomatic than Option, we can guard implementations of the std Error trait as necessary. That's what I've opted...

Yeah, that looks great, esp. with the grouping. I'd also consider dropping the extra wording (and use only the tag name) in favour of a hint when hovering. Thanks!

Yeah. The text can show up in a tooltip / hint when hovering over a tag.

Interesting. Have you tried to write your code so that you use a `Vec` instead? It would require uniform types, but this can be accomplished by using say enums and...