John-John Tedro

Results 237 comments of John-John Tedro

> I won't investigate why. Goooood call! Once I've given it a run over to make sure everything works as intended on my end as well I expect to merge...

This looks good and runs perfectly for me :tada: For anyone else: ```bash yarn install yarn package ``` Then open vscode with `editors/code` and run the `Run Extension` task. You...

Great! Someone artistically inclined will have to design rune icons. At least something which doesn't quite pop out as much as these yellow ones. I think I picked the right...

> Also the `Rune: Restart server` command throws some errors and I don't know how to fix them, but it does restart the server - so better than nothing. What's...

I'm not entirely following how this is different from the `INDEX_SET` and `SET` protocols (e.g. the former is `object[key]`, the latter `object.key`). Is this proposing that you should be able...

Ah, right. So `GET` only works for specific fields. It would be plausible to add support though so that it can work as a regular instance fn, like so: ```rust...

Hey. Thanks for outlining this! It is indeed expected behavior right now and I'll queue it up to be documented in the book. I'm not sure how to dynamically disallow...

@vi I'm not against adding weak references. All though I personally don't use them very much. If anyone else wants to give it a stab, feel free!

Note that most of the necessary plumbing to prevent the shared block from being de-allocated [is already in place](https://github.com/rune-rs/rune/blob/main/crates/runestick/src/shared.rs#L771). All you'd really need to do for an initial implementation is...

Started fiddling on the plumbing for a gc in the [gc branch](https://github.com/rune-rs/rune/tree/gc).