tytan652
tytan652
I just squashed all the commit together.
~~Put as draft to prioritize #53 over this.~~
Undraft to avoid the "*it's a draft so no need to review for now*" situation even if there is still some TODO.
> I think figuring out how to split this up into smaller pieces that we can incrementally build on instead of a giant overhaul would be a good thing to...
> It's probably worth doing an investigation to see if there are parts of the UI we can decouple as a prerequisite before the service overhaul. Beside the YouTube Actions...
I made a cleanup around old review conversations, some of them were closed with a comment some not because the RFC has really changed since then.
> OBS does not de-initialize encoders on RTMP stream start fail > 2\. Configure an RTMP or WHIP stream with an invalid stream key/bearer token Is it RTMP-only or it...
Blocked by #10658, once merged please update your code to only translate `UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in` and not `UI/xdg-data/com.obsproject.Studio.metainfo.xml.in`. The latter is in the deprecated CMake path, the former is the new one.
Yes I think the change about going away from xdg-data folder has completely gone unseen. We found out about it recently through metainfo regression in CI.
We enforce `QT_STYLE_OVERRIDE` which prevent QPA Platform Theme to apply their style over our theme, so this should not happen without setting `QT_STYLE_OVERRIDE`.