obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard
Published 2 weeks ago • verified publisher icon obsproject

CI: obs-crowdin-sync Python Rewrite

Open Vainock opened this issue 1 year ago • 4 comments

Description

Rewrites the obs-crowdin-sync repository in Python and adds the action to this repository.

Changes that come along with it:

  • Translates the UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in file.
  • Creates a pull request instead of pushing directly: https://github.com/Vainock/obs-studio/pull/4
  • Changes the name of English to English (USA) for en-US.
  • Lowers the requirements for new languages to be added to the UI/data/locale.ini.
  • Host the Language string in a separate Language Name file on Crowdin, remove it here.

Makes the organization/repository secret CROWDIN_SYNC_GITHUB_PAT obsolete.

Motivation and Context

The obs-crowdin-sync repository was too much for what it solves.

This solution is better for integration testing, easier to extend, easier for error analysis in the log because you don't have a huge bundled script and much cleaner to look at.

Pushing directly to the repo is bad, creating a PR is safer and transparent.

How Has This Been Tested?

Locally and https://github.com/Vainock/obs-studio/pull/4. The update-crowdin-locales action was tested in a obs-studio and obs-browser fork.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

Vainock avatar Apr 21 '24 09:04 Vainock

Blocked by #10658, once merged please update your code to only translate UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in and not UI/xdg-data/com.obsproject.Studio.metainfo.xml.in.

The latter is in the deprecated CMake path, the former is the new one.

tytan652 avatar May 09 '24 15:05 tytan652

@tytan652 Should it also update UI/cmake/linux/com.obsproject.Studio.desktop instead of UI/xdg-data/com.obsproject.Studio.desktop?

Vainock avatar May 11 '24 10:05 Vainock

Yes

I think the change about going away from xdg-data folder has completely gone unseen. We found out about it recently through metainfo regression in CI.

tytan652 avatar May 11 '24 11:05 tytan652

Ready for review.

Vainock avatar May 11 '24 11:05 Vainock