tytan652

Results 341 comments of tytan652

Since I re-written the RFC 45, this PR needed also a rewrite. So rewrite done, ~~only the doc addition is missing~~.

Rebase and fix memory leaks by using `bstrdup()` and return a `char *` rather than a `const char *` for `obs_output_get_prefix_protocol()`.

Is the usage of `sizeof(char)` a good idea rather than the size of the char array that got written into ?

You also need to use the return value of `snprintf()` on Linux because otherwise it could emit `format-truncation` warnings with GCC. - https://github.com/obsproject/obs-studio/pull/5653#discussion_r767311212 - https://github.com/obsproject/obs-studio/pull/5653#discussion_r848955534 - https://github.com/obsproject/obs-studio/commit/096ec55c8370052dd9d0547ad1a670b1bdd08f3f - https://github.com/obsproject/obs-studio/commit/ce62240530b0fc102b799be8f0fa824f7a746300

> `snprintf` is already used without checking for the return value throughout the codebase, don't those throw warnings as well? Check Ubuntu CIs, some of them (11-13) throw a format-truncation...

No more `-Wformat-truncation`, but three `-Wsign-compare` appeared (3 others are FTL). Some casts and they should be gone.

I need to cover more profile while testing, I thought that checking for H264 Constrained Baseline (non-LP) was enough. Can I have the output of the `vainfo --all` command to...

- Low power entrypoints are now allowed. - Only compatible rate control are shown. - Defaults is adapted against the first supported device. Edit: The next push will just be...

~~@WizardCM since you have a Intel iGPU, I need a verbose log made with this PR Flatpak. This is to check if I'm not the only one not having the...