tytan652
tytan652
We recently merged a rework of our CMake build-system. Now, `plugins/obs-ffmpeg/CMakeLists.txt` and `plugins/obs-ffmpeg/cmake/legacy.txt` should be updated.
uthash (headers only library) deps should be added to obs-deps. Ubuntu has the `uthash-dev` package.
*Moved to review*
Use `_QT_VERSION` not `QT_VERSION`, the latter is set to `AUTO`. `_QT_VERSION` is set to 5 or 6.
Nitpik on the commit name `Reduce` with a uppercase `R`.
Is it really a good idea to hardcode with an AAC value when in the future (while ignoring FTL) using an Opus encoder will be possible for recording, SRT and...
If the functions is not from a class (so no declaration). You should put the parameter name as comment. Like it was done in AJA: - https://github.com/obsproject/obs-studio/blob/8befd830a9807e35762006b9c715cdb133ab2c75/UI/frontend-plugins/aja-output-ui/aja-ui-main.cpp#L453 - Where it...
Rebased on #8090 to be able to work on top of all RFC 45 PRs.
Remove prefix related changes as it was done in the RFC.
After off-thread discussion `OBS_SERVICE_CONNECT_INFO_STREAM_KEY` is now an alias of `OBS_SERVICE_CONNECT_INFO_STREAM_ID` (and takes the value 2).