tytan652
tytan652
Then how should I name it rather than adding a 2, because the old function is deprecated because the custom QAction is no longer created and and the new one...
If you are talking about `obs_frontend_add_dock()`, it's a Frontend API function used by many plugins.
Renamed `obs_frontend_add_custom_dock` to `obs_frontend_add_custom_qdock`.
Replace QUuid usage in `obs_frontend_add_dock` by `os_generate_uuid`.
Added this note to the PR description: > Note: If `obs_frontend_add_custom_qdock()` usecase is something we want to avoid, review the code about removing it and deprecate the usecase through `obs_frontend_add_dock()`...
Old docks are now added before the separator if it exist. Edit: I just forgot to add that.
I think switching the view style (vertical to horizontal and vice versa) of the mixer may remove added sources through this method.
> @tytan652 how does this sound? I let @PatTheMav having the final say. > The worry that this job imposes a problem, seems a bit ... exaggerated to me. What...
> is the off-thread discussion available somewhere for external people like me? It was between OBS developers, so no. But long-story short it was a quick discussion about: - how...
> On the other hand, if someone has made the main window that small despite having more screen real estate, it's not the worst thing to respect that decision in...