tytan652

> How can adding new signals be an API breakage if you're required to listen to them and act upon those signals after they get triggered? Suddenly changing the behavior...

In case it was not understood, I'm not against adding global signals to output/encoder/service. But some of them created in the UI or in first-party plugins, may require to be...

> did you mean tweaking something in obs_enum itself, possibly adding `bool all` parameter, so that obs_enum_all_sources could do other things than the rest, that are all using obs_enum internally?...

Thank you for making the change. I think all my concerns about the signal additions are addressed. Still needs testing and review of the code.

> I'm just worried that the PR gets lost, Don't worry, it will not. It may just take some time. > this is is still saying "changes requested" This is...

A log of the CMake configuration and build are needed to have the needed information. The issue will be closed after one week if those are not posted on this...

So GCC 12.3.0, building on Arch Linux (GCC 13) does not have issue. ~~If I have to guess the NixOS buildsystem add compile flags such as `-Wsign-compare`, adding such flags...

``` (pParams->nWidth * pParams->nHeight) >= pixelcount_4k) { ``` The three values are unsigned so why `-Wsign-compare` gets there, maybe a library issue or a compiler regression ?

CMake 3.0 does not provide support for system ftl-sdk install.

Made a packaging test build on Arch Linux and many headers are missing as it is. ~~`example.h`~~ indicate a missing header compared to a build without the PR. ![Screenshot from...