obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard
Published 2 weeks ago • verified publisher icon obsproject

RFC 45-1: Add protocol in Outputs API and check service protocol in the "UI"

Open tytan652 opened this issue 4 years ago • 4 comments

Description

This PR is about the RFC 45.

  • Add a "protocols" and "protocols_prefixes" fields in obs_output_info and add protocols to outputs meant for services.
  • Add the function obs_output_get_prefix_protocol which return a protocol if the URL prefix is known.
  • Make the UI skip services where the protocol is not registered and also skip RTMPS servers for service providing RTMP and RTMPS server when the later is not registered.

Motivation and Context

Part of the implementation of the RFC 45.

How Has This Been Tested?

Artifacts from Github actions will not much help with testing this PR since it build with all protocol support.

  • Build OBS without FTL support and check if "Glimesh" service is not shown.
  • Build OBS without RTMPS support and check if "YouTube - RTMPS" RTMPS servers, "Facebook Live" service and "STAGE TEN" are not shown, RTMPS servers from other services are also not shown.
  • Build OBS with support for both and check those three services are shown.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
    • Showing services that are not supported is sort of a bug
  • New feature (non-breaking change which adds functionality)
  • Documentation (a change to documentation pages)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

tytan652 avatar Aug 09 '21 12:08 tytan652

Since I re-written the RFC 45, this PR needed also a rewrite. So rewrite done, ~~only the doc addition is missing~~.

tytan652 avatar Aug 21 '21 07:08 tytan652

Rebase and fix memory leaks by using bstrdup() and return a char * rather than a const char * for obs_output_get_prefix_protocol().

tytan652 avatar Sep 13 '22 11:09 tytan652

Removed useless !! in if ().

tytan652 avatar Oct 07 '22 18:10 tytan652

Add missing changes in the JSON Schema.

~~I moved an element by accident I will push to remove this changes soon.~~

tytan652 avatar Jan 27 '23 12:01 tytan652

Improved obs_register_output_s changes (stop using simple NULL checks).

tytan652 avatar Feb 16 '23 13:02 tytan652

Remove prefix related changes as it was done in the RFC.

tytan652 avatar Mar 11 '23 20:03 tytan652

No longer enforce the "protocol" field in the JSON if the server URL is a RTMP(S) one.

tytan652 avatar Mar 13 '23 09:03 tytan652