optimism icon indicating copy to clipboard operation
optimism copied to clipboard

maint(ct): no full ethers in entrypoint

Open smartcontracts opened this issue 2 years ago • 3 comments

Description Updates the contracts package so that the files imported by the entrypoint do not use the full ethers package and only use submodules. Useful because this allows people to only import specific submodules of ethers and not have to bundle the entire ethers package.

smartcontracts avatar Sep 21 '22 03:09 smartcontracts

🦋 Changeset detected

Latest commit: 6661f0f1575aa676502c156ced837922156f9e0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 21 '22 03:09 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Sep 21 '22 03:09 mergify[bot]

Looks like an ethers peer dep problem with smock

1) L1ChugSplashProxy
       fallback
         should throw an error if the owner has signalled an upgrade:
     TypeError: abi.map is not a function
      at new Interface (/root/project/node_modules/ethers/node_modules/@ethersproject/abi/src.ts/interface.ts:100:47)
      at Object.ethersInterfaceFromSpec (/root/project/node_modules/@defi-wonderland/smock/src/factories/ethers-interface.ts:24:12)
      at Sandbox.fake (/root/project/node_modules/@defi-wonderland/smock/src/sandbox.ts:42:13)
      at Object.fake (/root/project/node_modules/@defi-wonderland/smock/src/index.ts:12:24)
      at async Context.<anonymous> (test/contracts/chugsplash/L1ChugSplashProxy.spec.ts:169:21)

tynes avatar Sep 21 '22 12:09 tynes

Getting some weird access error in CI...

smartcontracts avatar Sep 23 '22 02:09 smartcontracts

The build error is happening in contracts-governance which is pretty strange. Perhaps a hardhat versioning thing?

tynes avatar Sep 25 '22 18:09 tynes

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Sep 27 '22 15:09 mergify[bot]

Still trying to get this merged @smartcontracts ?

tynes avatar Sep 30 '22 21:09 tynes

Going to put this on hold until after I get back from devcon

smartcontracts avatar Oct 06 '22 19:10 smartcontracts

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 21 '22 02:10 github-actions[bot]

Closing this - please reopen once you've had a chance to return to this.

mslipper avatar Oct 26 '22 04:10 mslipper