fix(ct): bug in L2OutputOracle constructor

[smartcontracts]

Description Fixes a small bug in the L2OutputOracle constructor where an assertion was being made about the wrong value. Unlikely that this would've caused any significant issues but worth fixing anyway.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: e8b54e4043710d19c191d4305913739ba0d80fc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@eth-optimism/contracts-bedrock	Patch
@eth-optimism/actor-tests	Patch
@eth-optimism/sdk	Patch
@eth-optimism/drippie-mon	Patch
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[maurelian]

I approve this, but now that I think about it we really need to have the discipline of writing a test every time we fix a bug. even when it's a trivial one like this. would really appreciate if you'd be so kind as to oblige me on that.

[smartcontracts]

SGTM!

[smartcontracts]

I approve this, but now that I think about it we really need to have the discipline of writing a test every time we fix a bug. even when it's a trivial one like this. would really appreciate if you'd be so kind as to oblige me on that.

Done

[mslipper]

@smartcontracts mind updating the gas snapshot + bindings?

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[tynes]

This needs code to handle the L1 genesis creation

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mslipper]

This is causing a bug somewhere:

Failed
=== RUN   TestBuildL1DeveloperGenesis
    layer_one_test.go:32: 
        	Error Trace:	/root/project/op-chain-ops/genesis/layer_one_test.go:32
        	Error:      	Received unexpected error:
        	            	no code found for L2OutputOracle
        	Test:       	TestBuildL1DeveloperGenesis
--- FAIL: TestBuildL1DeveloperGenesis (0.01s)

[mergify[bot]]

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

[mslipper]

This is breaking tests because the Geth simulated backend that deploys the contracts on L1 in the devnet sets the block timestamp to zero. We can fix this, but it'll require changes in op-geth to allow you to specify the block timestamp in the simulator.

[mergify[bot]]

This PR has been added to the merge queue, and will be merged soon.

[mergify[bot]]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[mergify[bot]]

This PR is next in line to be merged, and will be merged as soon as checks pass.