Travis Bischel
Travis Bischel
Looks like an easy fix, mind opening a PR?
Hi there, I haven't looked at this code in about four years now. I'd be open to a PR though?
I'm not a gate on this repo, I just saw the PR and decided to look since I fixed roughly the same thing in my own fork from way back.
Fundamentally, the unsafe code needs changing. Feel free to take my patches: https://github.com/twmb/murmur3/compare/b0c3ada...HEAD Note that using binary.LittleEndian (or my path) will resolve this repos tickets around issues across architectures, as...
FWIW DataDog/mmh3 theoretically same unaligned input problem, but I think it goes through unsafe & reflect.SliceHeader in a roundabout enough way that the new checks don't catch it: ```go h...
Likely, but for what it's worth only the warning was removed, the underlying issue the warning was about still exists. Given that nobody complained about the issue in years, it...
https://buildkite.com/redpanda/redpanda/builds/13690#01826ed3-0a49-4212-8cdb-dc348c88ff3d/6-6678
It might be worth it to check out my generated protocol definitions that implement serializing and deserializing all requests/responses through all versions: https://github.com/twmb/franz-go/blob/master/pkg/kmsg/generated.go
When this happens, can you capture the logs with `-v`? The client already retries, but only if the most recently loaded metadata is older than 1s. For groups, not_coordinator errors...
Another alternative is to add a `MetadataMinAge(10*time.Millisecond)` and see if that makes this more rare (just checked, the internal lower limit is 10ms)