Travis Bischel

Results 293 comments of Travis Bischel

How about a NoAttempt method on messages and extending the protocol internally to include `NOA` or something similar? On consumer shutdown, all messages in flight could be remarked as not...

Makes sense. I don't fully understand how a repeated run is able to insert an extra newline, that would be interesting to know. I wonder if there's a more general...

This sounds good. For the case of `nsq_to_nsq`, the first error returned would also backoff the consumer side, which would be decent. The only thing that I don't like about...

I like to think of it as "oh hey, while consuming I got in a bad state, I'm going to set my RDY to 0 and also not even look...

I suppose that's true, which means this issue can go forward, but I still think that `NoAttempt` would be a useful addition :).

Sure, the code could do for a cleanup. I'm quite busy for a while, so I don't have time to get to the code myself, but I should be able...

I think an "install" block might be useful, since there are many modules in this one repo which is pretty uncommon.

This does look weird. The error is coming within the client and happens when the `Username` field is not set. I see you're initializing both sarama and franz-go identically, so...

Transactions are so filled with edge cases that I'd have to think a good bit to see what would break by handing over a bit more control -- the main...

> real blocker So, if I add the ability to mark individual records (partitions, really -- strictly advance within a partition) as available to commit, so that a session isn't...