Travis Bischel

Results 293 comments of Travis Bischel

With AddOffsetsToTransaction, are you thinking this is a 1:1 mapping to the underlying TxnOffsetCommitRequest? A problem with exposing this is that there are three different cases that _should_ be handled...

Is SendOffsetsToTransaction synchronous? Also, I'm open to a PR so long as there's a lot of documentation on when something should or shouldn't be used, and the safety concerns around...

IIRC the Java client is implemented such that the producer and consumer have no knowledge of each other, which actually makes safety guarantees a lot harder. Separating this into a...

Hi @salsorrentino! This will be my last ping on this issue before closing it. I think my proposal above addresses your needs, lmk what you think if possible. I'm _probably_...

What's the recommendation? Alternatively, PR?

There are already two examples linked in the metrics & logging section of the readme: https://github.com/twmb/franz-go/#metrics--logging https://github.com/twmb/franz-go/tree/master/examples/hooks_and_logging/expansive_prometheus https://github.com/twmb/franz-go/tree/master/examples/hooks_and_logging/plugin_prometheus as well as another use case in the bench code (another example,...

Yes that's the proper solution. Someday, the minimal version should be bumped to go1.16 -- 1.15 has been unsupported for two releases now.

What's the output of running the first command?

Sorry, kcl is a bit lower priority for me at the moment. Everything above looks correct: what's the output of using the password? I remember when I tried this a...