Travis Bischel

Results 293 comments of Travis Bischel

kgo: add TopicID to the FetchTopic type

Bit of a delay on my side ... releasing this evening.

high number of allocations in `kgo.recordToRecord` function

I see you took your proposal a good bit further in https://github.com/grafana/franz-go/pull/3. I used to have a `sync.Pool` for records internally, but removed it due to due to it being...

high number of allocations in `kgo.recordToRecord` function

I've read through the PRs in the forked repo, I have a proposal that is a bit different. There are three areas that the fork introduces caching to: * The...

high number of allocations in `kgo.recordToRecord` function

I've merged the PR that adds memory pooling (and also has a few other features), I'm going to close this. This will be released in 1.19, which primarily only the...

high number of allocations in `kgo.recordToRecord` function

This is released.

pkg/kfake: consumer group goroutines don't exit on cluster shutdown

A couple thoughts: * I think the `wg` is added only so that you can ensure that started goroutines are _done_ by the time the client exits, solely so that...

Race condition in TestPartitionReader_ConsumeAtStartup

Is this a race I should look at / does it occur with a newer franz-go?

Users not created from mTLS certificates

Closing as stale please reopen if needed.

kprom: Support for multiple clients

I'm open to this, what's the proposed API?

kprom: Support for multiple clients

Per request in the PR, I'm closing this. I'm still open to moving forward with the PR (there were a few outstanding questions) but I'm not sure it's needed given...