Travis Bischel
Travis Bischel
Barring feedback, I'll implement option 2 for the next minor release. `DeepPing` will use a produce connection unless the client is not a producer.
I've touched up #839. After looking deeper at Ping, Ping _does_ deeply ping a broker. Given that, there was little reason to introduce DeepPing. I've changed the implementation you originally...
This is released.
Are you exiting the poll loop somewhere without allowing rebalance? You may want to check `CloseAllowingRebalance()`.
That will work, but I'll leave this issue open as a reminder to spot check if any APIs are worth mirroring to GroupTransactSession.
From a quick audit, I think only AllowRebalance and CloseAllowingRebalance are worth adding to GroupTransactSession -- for other APIs, a user can go through Client()
Bit of a delay on my side ... releasing this evening.
The more I look at this, the more I think this needs to be done via (2) or (3), not (1). Saving for the next next release.
This is released.
I'm on board, though I'd skip (2). I think this is the full patch: ```diff diff --git a/pkg/kgo/record_and_fetch.go b/pkg/kgo/record_and_fetch.go index 4f1ebe6f..55315644 100644 --- a/pkg/kgo/record_and_fetch.go +++ b/pkg/kgo/record_and_fetch.go @@ -274,6 +274,8 @@...