Build failed when using go 1.15 and franz-go 1.6.0

Open ly931003 opened this issue 2 years ago • 2 comments

github.com/twmb/franz-go/pkg/kgo

/root/go/pkg/mod/github.com/twmb/[email protected]/pkg/kgo/record_formatter.go:1588:13: undefined: io.ReadAll

io.ReadAll not available in go 1.15

Jun 24 '22 04:06 ly931003

Maybe we can replace io.ReadAll with ioutil.ReadAll. As of Go 1.16, ioutil.ReadAll simply calls io.ReadAll.

Jun 24 '22 05:06 ly931003

Yes that's the proper solution.

Someday, the minimal version should be bumped to go1.16 -- 1.15 has been unsupported for two releases now.

Jun 24 '22 21:06 twmb

This will be out in v1.6.1 or v1.7.0, whichever comes first.

Aug 05 '22 20:08 twmb

Since this is minor and the only change so far for 1.6.0, I'll probably wait until I address #175 and then release both at once for 1.7.0

Aug 05 '22 20:08 twmb

This has been released in v1.7

Aug 23 '22 05:08 twmb