Thomas Jeffery

Results 50 comments of Thomas Jeffery

Thanks for the review @Spark450! I've addressed all of your comments. I have a couple things I will check with development on, otherwise I think it's all completed so far

This issues is needed for this update to the design system website to show issue counts from Github per component: https://github.com/GovAlta/ui-components-docs/pull/337 [Deploy preview](https://deploy-preview-337--abgov-ui-component-docs.netlify.app/components#tab-1)

[design contribution file](https://www.figma.com/design/EAxRTUNwcpwIhBvVCl3GjK/Component---Time-picker?node-id=3-378) in Figma tracking designs for this issue

Elmira in Land titles is currently working on this and has research that can be used: https://miro.com/app/board/uXjVK3iMNt4=/

Collected designs are in a [design contribution file here](https://www.figma.com/design/cKva6lrD7QfINC4hihHE7A/Component---Quick-exit-Hide-this-page?node-id=1905-5494&t=bPLdUjfJDZ2CJm7r-4)

I cannot replicate this, I see 42px, except for the input type=date, which I just put up a fix for: https://github.com/GovAlta/ui-components/pull/2669 When going through with Dustin, the PR #2669 fixes...

I think we should make sure to handle this in the developed component like the container, so that a team can put anything they want inside, use a goa-grid, goa-block,...

@Spark450 @Spark450 where do we have this completed?

> @twjeffery Could you please confirm below? Is deletable property supposed to be true by default? Is the close icon always required or can we also have a basic chip...

Full layout and breakpoints outlined for our design system website here in Figma: https://www.figma.com/design/qWGWDvULAAZuVaDpXCRzqP/DS-Reference-website?node-id=6562-327372&t=hHYFscclLH5ywRwU-4