Thomas Jeffery

Results 50 comments of Thomas Jeffery

@ArakTaiRoth @Spark450 https://jam.dev/c/f9c4ea84-a6d3-4779-afef-02ecf8c999d7

> @Spark450 @twjeffery It might be a sandbox thing, or it's actually fixed in the latest version, because I can't replicate doing the exact same thing as that jam link...

@bdfranck Thanks for the detailed review and changes. I've implemented everything you included and will squash into one commit. One additional thing I saw was that we need after testing...

> @twjeffery I had a thought as I reviewed this: should the focus state also trigger the over state? > > I noticed that they do on your icon button...

> @twjeffery I've amended the commit to address all your comments. I'm not sure why semi-bold isn't displaying properly. I triple checked that the value is `600`. My best guess...

@bdfranck brilliant simplifications, thank you for making this much better code then it was. I've added all of your suggested changes! **Also, when I was testing this again, I found...

@bdfranck @chrisolsen re-requesting reviews after changing the base branch to dev

> @twjeffery I noticed that you removed the following tokens in your [latest changes](https://github.com/GovAlta/ui-components/compare/1f3c981203df401a28c0d6b30326ae09911cc390..e08f7d448b81b0fac2bc0613ff0c985f82018178) since our reviews: > > * `goa-accordion-icon-color-hover` > * `goa-accordion-icon-color` > * `goa-accordion-heading-min-height` > > What...

> [@twjeffery](https://github.com/twjeffery) would you say that what this issue is trying to get at is covered by your work on the public form "kit"? yup, it is: #2590

@Spark450 I think this is all included here in the first version of the [Public form prototyping kit](https://www.figma.com/design/JUacsxcjzeMipVHmOvIqyo/-Draft--Public-form-prototyping-kit?node-id=139-533923) in Figma. Can you review when you have time?