Thomas Jeffery
Thomas Jeffery
@bdfranck I committed your suggested changes and squashed it back into one commit for us to merge
> Looks good! I just have two more questions about the margins around the icon. @bdfranck I appreciate the review, it should be fixed now, I've pushed updates to both...
@bdfranck updated with your feedback. I pushed an update to this PR and the [design tokens PR](https://github.com/GovAlta/design-tokens/pull/97)
As Benji mentioned, currently this can be worked around with margin: none on the last checkbox in a group. Additional spacing adjusted in this PR: https://github.com/GovAlta/ui-components/pull/2296 It would be nice...
> Looking good! I have some questions and recommendations about the CSS. Let me know if you want to discuss anything. Thanks @bdfranck, all changes made. I also noticed a...
> Looks good! Just one more small tweak. @bdfranck Updated!
@bdfranck @chrisolsen re-requesting reviews after changing the base branch to dev
I fixed this as part of the style update work for drawer, here: https://github.com/GovAlta/ui-components/pull/3157
First version of this completed here: https://www.figma.com/design/JUacsxcjzeMipVHmOvIqyo/-Draft--Public-form-prototyping-kit?node-id=139-533923 @Spark450 can you review when you have some time, along with #2602
@bdfranck **1. Back button** Sounds good **2. Submenu items** Sounds good **3. Menu state persistence** For sure, it might be a playground issue that wouldn't be an issue for teams....