Thomas D'Silva

Results 10 comments of Thomas D'Silva

Thanks for the patch @yanxinyi . Looks pretty good, can you please create a patch and submit it on the JIRA so that we can get a a test run?...

@geraldss I tried running your test without the fix and it still passes. The compiler optimizes the query to use SKIP-SCAN-JOIN so the hash cache is not sent to the...

Automatic querying of materialized views is not currently supported. We plan on adding query support in the future by using calcite's materialized view feature https://calcite.apache.org/docs/materialized_views.html. The materialized views would have...

Thanks for the JIRA @huukhuongnguyen, can you please post how to reproduce the exception you are seeing?

@danicat Thanks for the contribution, please file a JIRA for tracking purposes so that this PR can be committed.

@jaanai0 From the example that @dbwong gave, I don't think we can support decreasing the length of a column. If the column is present in an index this can cause...

@karanmehta93 or @gjacoby126 can you also please review and commit this patch if it looks good?

LGTM, with this change does it pick the unioned query over the one that just uses the fact table ?