PHOENIX-4917 Fix ClassCastException when projecting array elements in hash join

[geraldss]

cc @twdsilva @JamesRTaylor @joshelser Ready for review. Thanks.

[geraldss]

@twdsilva This pull request now includes a new test using a mini-cluster. Please review, thanks.

[twdsilva]

@geraldss I tried running your test without the fix and it still passes. The compiler optimizes the query to use SKIP-SCAN-JOIN so the hash cache is not sent to the server. The explain plan is CLIENT PARALLEL 1-WAY FULL SCAN OVER UNSALTED_N000001 SERVER ARRAY ELEMENT PROJECTION SKIP-SCAN-JOIN TABLE 0 DYNAMIC SERVER FILTER BY UNSALTED_N000001.ID IN ($1.$3)

I will just commit your original PR without the test since it doesn't add anything. You can file a separate JIRA to fix ProjectArrayElemAfterHashJoinIT to actually test HashJoin.

[stoty]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Comment
+0 :ok:	reexec	5m 32s	Docker mode activated.
		_ Prechecks _
+1 :green_heart:	dupname	0m 0s	No case conflicting files found.
+1 :green_heart:	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 :green_heart:	@author	0m 0s	The patch does not contain any @author tags.
-1 :x:	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 :green_heart:	mvninstall	21m 1s	master passed
+0	hbaserecompile	32m 23s	HBase recompiled.
+1 :green_heart:	compile	1m 4s	master passed
+1 :green_heart:	checkstyle	0m 56s	master passed
+1 :green_heart:	javadoc	0m 53s	master passed
+0 :ok:	spotbugs	3m 5s	phoenix-core in master has 972 extant spotbugs warnings.
-0 :warning:	patch	3m 14s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
-1 :x:	mvninstall	0m 30s	root in the patch failed.
+0	hbaserecompile	15m 25s	HBase recompiled.
-1 :x:	compile	0m 20s	phoenix-core in the patch failed.
-1 :x:	javac	0m 20s	phoenix-core in the patch failed.
+1 :green_heart:	checkstyle	0m 55s	the patch passed
-1 :x:	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 :x:	whitespace	0m 0s	The patch 30 line(s) with tabs.
+1 :green_heart:	javadoc	0m 50s	the patch passed
-1 :x:	spotbugs	0m 18s	phoenix-core in the patch failed.
		_ Other Tests _
-1 :x:	unit	0m 19s	phoenix-core in the patch failed.
+1 :green_heart:	asflicense	0m 15s	The patch does not generate ASF License warnings.
		60m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/phoenix/pull/358
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux 7704385c681c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / bfc4621
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javac	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-tabs.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/testReport/
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

Already merged.