phoenix
phoenix copied to clipboard
PHOENIX-3817 Verify Replication using SQL conditions
The motivation is to be able to verify replication between two tables - source and a target table (on same or some other cluster) , based on some sql conditions. Per source input split an aligned target scan is retrieved, the verification is done by comparing rows once the start row is aligned. Based on the comparison the target scan row is moved. This approach is scn aware. I will be including more test scenarios in future updates.
@vincentpoon @karanmehta93 @aaraujo @gjacoby126 @twdsilva Will appreciate your review feedback! Thanks.
Thanks for the feedback @karanmehta93 ! I will look into the changes.
It would be good to add some comments @akshita-malhotra once you are done with the dev part.
@karanmehta93 Updated the test suite based on your comments. Added some more comments, will add some more :) @twdsilva Reused the split system catalog logic as per your suggestion, seems to be working well. It would be great if you can take another pass at the PR. @gjacoby126 @vincentpoon Please take a look whenever you get a chance.
@aaraujo, @apurtell : It will be great if you can take a look as well. Thank you
@karanmehta93 or @gjacoby126 can you also please review and commit this patch if it looks good?
@gjacoby126 Thanks a lot for the review. I will incorporate the changes and update the PR and jira patch.
Hey @akshita-malhotra, I'll take a look at your next patch!