phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-3817 Verify Replication using SQL conditions

Open akshita-malhotra opened this issue 6 years ago • 8 comments

The motivation is to be able to verify replication between two tables - source and a target table (on same or some other cluster) , based on some sql conditions. Per source input split an aligned target scan is retrieved, the verification is done by comparing rows once the start row is aligned. Based on the comparison the target scan row is moved. This approach is scn aware. I will be including more test scenarios in future updates.

akshita-malhotra avatar Jul 11 '18 05:07 akshita-malhotra

@vincentpoon @karanmehta93 @aaraujo @gjacoby126 @twdsilva Will appreciate your review feedback! Thanks.

akshita-malhotra avatar Jul 19 '18 22:07 akshita-malhotra

Thanks for the feedback @karanmehta93 ! I will look into the changes.

akshita-malhotra avatar Jul 20 '18 03:07 akshita-malhotra

It would be good to add some comments @akshita-malhotra once you are done with the dev part.

karanmehta93 avatar Jul 23 '18 18:07 karanmehta93

@karanmehta93 Updated the test suite based on your comments. Added some more comments, will add some more :) @twdsilva Reused the split system catalog logic as per your suggestion, seems to be working well. It would be great if you can take another pass at the PR. @gjacoby126 @vincentpoon Please take a look whenever you get a chance.

akshita-malhotra avatar Aug 15 '18 00:08 akshita-malhotra

@aaraujo, @apurtell : It will be great if you can take a look as well. Thank you

akshita-malhotra avatar Aug 15 '18 21:08 akshita-malhotra

@karanmehta93 or @gjacoby126 can you also please review and commit this patch if it looks good?

twdsilva avatar Aug 24 '18 18:08 twdsilva

@gjacoby126 Thanks a lot for the review. I will incorporate the changes and update the PR and jira patch.

akshita-malhotra avatar Sep 05 '18 21:09 akshita-malhotra

Hey @akshita-malhotra, I'll take a look at your next patch!

aaraujo avatar Sep 07 '18 10:09 aaraujo