Tung D. Le

Results 136 comments of Tung D. Le

~Expected outputs for Round looks incorrect #3755.~ This one has been resolved. (Edited by @jcwchen)

I feel that we have more and more environment variables for a single test. Could it be better to use a single environment variable, say TEST_CONV_OPTS="-static -d=1 -padding=valid_upper"? Similar for...

As I know, these names will be used to generate global constants in LLVM, so even at this high level we must ensure that they are unique. In that sense,...

We are not going to write shape inference code directly in ONNXOps.cpp but put them into folder `src/Dialect/ONNX/ShapeInference`. Also, we should use IndexExpr to compute shape inference because it will...

@DavidChan0519 could you please sign DCO so that we can merge this? Thanks!

@DavidChan0519 this is the suggested instruction to fix DCO: https://github.com/onnx/onnx-mlir/pull/1267/checks?check_run_id=8105622451

@Connor-XY Is it possible to share more information, for example, the onnx model or a simplified onnx model that caused the issue?